Module:ModifierTables: Difference between revisions

Module:ModifierTables (view source)

203 bytes added , 25 October 2022

Fix skill ID determination

12,721

edits

@@ Line 24: / Line 24: @@
  if skill == '' then
  skill = nil
- elseif type(skill) == 'string' then
+ elseif Constants.getSkillID(skill) ~= nil then
+ -- skill is a skill name
  skill = Constants.getSkillID(skill)
+ elseif Constants.getSkillName(skill) == nil then
+ -- skill is neither a skill name or ID
+ return 0
  end
@@ Line 210: / Line 214: @@
  if skill == '' then
  skill = nil
- elseif type(skill) == 'string' then
+ elseif Constants.getSkillID(skill) ~= nil then
- local skillID = Constants.getSkillID(skill)
+ -- skill is a skill name
- if skillID == nil then
+ skill = Constants.getSkillID(skill)
- return 'ERROR: Failed to find a skill ID for ' .. skill .. '[[Category:Pages with script errors]]'
+ elseif Constants.getSkillName(skill) == nil then
- else
+ -- skill is neither a skill name or ID
- skill = skillID
+ return 'ERROR: Failed to find a skill ID for ' .. skill .. '[[Category:Pages with script errors]]'
- end
  end